-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Commands: Allow command context to be an array #55341
base: trunk
Are you sure you want to change the base?
Conversation
…ded in multiple contexts
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
Size Change: +15 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
Flaky tests detected in 9bc932a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6506072564
|
What?
Just an exploration to see if command contexts can be easily extended to allow for an array
Why?
Sometimes it might make sense to load commands in multiple contexts, eg. #55332, and currently to do this the same loader would need to be registered twice.
How?
Updates the
getCommandLoaders
selector` to check if the context is an array or a string.Testing Instructions
Will add testing instructions if we decide this is a good idea.
Testing Instructions for Keyboard
Screenshots or screencast